Skip to content

Commit

Permalink
[test] OTP 23+ is required for Phoenix 1.7+
Browse files Browse the repository at this point in the history
  • Loading branch information
cpjolicoeur committed May 16, 2023
1 parent f51cbe9 commit 558a70d
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions bin/test
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@
TEST_ROOT="$(pwd)/test"
ASSETS_ROOT="$(pwd)/assets"

MIX_ENV=test mix compile --warnings-as-errors --force || {
mix compile --warnings-as-errors --force || {
echo 'Please fix all compiler warnings.'
exit 1
}
MIX_ENV=test mix credo --strict --ignore design,consistency || {
mix credo --strict --ignore design,consistency || {
echo 'Elixir code failed Credo linting. See warnings above.'
exit 1
}
MIX_ENV=test mix docs || {
mix docs || {
echo 'Elixir HTML docs were not generated!'
exit 1
}
Expand Down Expand Up @@ -60,9 +60,9 @@ echo "[DEBUG] Current Elixir Version: $iexCurrentVersion"
otpCurrentVersion="$(erl -eval 'erlang:display(erlang:system_info(otp_release)), halt().' -noshell | sed 's/\"//g')"
echo "[DEBUG] Current OTP Version: $otpCurrentVersion"

requiredMinVersion="24"
requiredMinVersion="23"
if [ "$(printf '%s\n' "$requiredMinVersion" "$otpCurrentVersion" | sort -Vr | head -n1)" = "$requiredMinVersion" ]; then
echo '[Skipping] OTP 24+ is required for Phoenix 1.7+'
echo '[Skipping] OTP 23+ is required for Phoenix 1.7+'
else
cd "$TEST_ROOT/support/apps/phx1_7" && {
bin/test || {
Expand Down

0 comments on commit 558a70d

Please sign in to comment.