Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aggregate for combination queries #100

Closed
wants to merge 7 commits into from

Conversation

iguberman
Copy link

@iguberman iguberman commented Dec 8, 2021

Fixes #99)

@iguberman iguberman changed the title Fix composite queries aggregate Fix aggregate for combination queries Dec 8, 2021
@drewolson
Copy link
Contributor

@iguberman thanks for the PR! I've noticed you've been incrementally adding some commits. Is this ready for review / merge or are you still working on it?

@kelostrada
Copy link

==> scrivener_ecto
Compiling 2 files (.ex)
warning: variable "caller" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/scrivener/paginater/ecto/query.ex:48: Scrivener.Paginater.Ecto.Query.total_entries/4

warning: variable "count_query" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/scrivener/paginater/ecto/query.ex:57: Scrivener.Paginater.Ecto.Query.total_entries/4

warning: variable "prefix" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/scrivener/paginater/ecto/query.ex:49: Scrivener.Paginater.Ecto.Query.total_entries/4

warning: variable "expr" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/scrivener/paginater/ecto/query.ex:89: Scrivener.Paginater.Ecto.Query.aggregate/1

please fix the warnings.

Also run: mix format

@cpjolicoeur
Copy link
Member

[Fixed by #98]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UNION queries fail
4 participants