Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename submitSelector to findSubmit #252

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rename submitSelector to findSubmit #252

wants to merge 1 commit into from

Conversation

buob
Copy link

@buob buob commented Sep 11, 2014

Finishes #247

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling d7f960c on jb/rename-submit-selector into 8ab8fc5 on master.

@samccone
Copy link
Contributor

Weird we do not have any tests for this, we should add one :)

@samccone
Copy link
Contributor

@buob lets add a console.warn under the old method and simply have it proxy to the new method to alert people to change their code so that this can be "non" breaking

@sethkrasnianski
Copy link
Member

console.warn("Deprecated, bro. :facepunch:")

@samccone
Copy link
Contributor

http://nodejs.org/api/console.html#console_console_warn_data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@buob @coveralls @samccone @sethkrasnianski