Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stdlib] Introduce fixed-width bin and hex #3694

Draft
wants to merge 1 commit into
base: nightly
Choose a base branch
from
Draft

[stdlib] Introduce fixed-width bin and hex #3694

wants to merge 1 commit into from
+111 −1

Conversation

soraros
Copy link
Contributor

@soraros soraros commented Oct 18, 2024

fix #3671

martinvuyk
martinvuyk reviewed Oct 18, 2024
View reviewed changes
Copy link
Contributor

@martinvuyk martinvuyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, though maybe add some explicit mention in the docstrings that this deviates from Python's format spec and how (examples would work best here IMO). I think it might confuse ppl otherwise why there are different versions in separate modules

stdlib/src/bit/bit.mojo Show resolved Hide resolved
stdlib/src/memory/unsafe.mojo Show resolved Hide resolved
@soraros
Copy link
Contributor Author

soraros commented Oct 21, 2024

@martinvuyk Writing examples in the docstring is a good idea.

@soraros
[stdlib] Introduce fixed-width bin and hex
7b88131 
Signed-off-by: Yiwu Chen <210at85@gmail.com>
@JoeLoser
Copy link
Collaborator

JoeLoser commented Nov 1, 2024

!sync

@soraros
Copy link
Contributor Author

soraros commented Nov 1, 2024

@JoeLoser I still need to improve the doc string, add tests and maybe a changelog entry for this one.

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinvuyk martinvuyk martinvuyk left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@JoeLoser JoeLoser

Labels
imported-internally Signals that a given pull request has been imported internally.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soraros @JoeLoser @martinvuyk @modularbot