Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stdlib] Rename SIMD.value to SIMD._value. #3693

Open
wants to merge 1 commit into
base: nightly
Choose a base branch
from
Open

[stdlib] Rename SIMD.value to SIMD._value. #3693

wants to merge 1 commit into from

Conversation

helehex
Copy link
Contributor

@helehex helehex commented Oct 18, 2024

Use an alias for the underlying mlir type of the _value, to match the rest of the stdlib.

@helehex helehex requested a review from a team as a code owner October 18, 2024 18:17
@helehex
Rename SIMD.value to SIMD._value.
5201e57 
Use an alias for the underlying mlir type in `SIMD`.

Signed-off-by: Max Brylski <helehex@gmail.com>
JoeLoser
JoeLoser approved these changes Oct 19, 2024
View reviewed changes
Copy link
Collaborator

@JoeLoser JoeLoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JoeLoser
Copy link
Collaborator

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeLoser JoeLoser JoeLoser approved these changes

Assignees

@JoeLoser JoeLoser

Labels
imported-internally Signals that a given pull request has been imported internally.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@helehex @JoeLoser @modularbot