Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update description in view.schema.json #113

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

imagejan
Copy link
Contributor

@imagejan imagejan commented Jul 8, 2024

Fix formatting of html-like tags in description string.

I'm unsure how https://github.com/mobie/mobie.github.io/blob/master/specs/mobie_spec.md is generated from the content of the spec files like https://github.com/mobie/mobie.github.io/blob/master/schema/view.schema.json, but on https://mobie.github.io/specs/mobie_spec.html these fields are currently interpreted as HTML tags and therefore rendered wrongly.

I edited view.schema.json only, but the change will be required in the markdown file as well, I guess.

Fix formatting of html-like tags in description string
@tischi
Copy link
Contributor

tischi commented Jul 8, 2024

I am not sure here...

@constantinpape could you please have a look at this?

@constantinpape
Copy link
Contributor

Thanks @imagejan. The markdown generation is done with this script:
https://github.com/mobie/mobie.github.io/blob/master/scripts/generate_spec_description.py

You can see if running this and committing the output works on your end, otherwise I can give it a try.

(And ideally the CI would take care of this, but I didn't have the time for that.)

@constantinpape constantinpape merged commit 241e106 into mobie:master Jul 8, 2024
1 check passed
@imagejan imagejan deleted the patch-1 branch July 8, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants