Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix display of project creator ui on high dpi screens #1054

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Fix display of project creator ui on high dpi screens #1054

merged 2 commits into from
Aug 11, 2023

Conversation

K-Meech
Copy link
Contributor

@K-Meech K-Meech commented Aug 3, 2023

Fixes #1051

Main changes are in ProjectsCreatorPanel.java - rest are just documentation updates:

  • Removes hardcoded widths/heights of labels/buttons/comboboxes
  • Switches to use GridBagLayout to ensure ui components stay aligned
  • Updates Javadoc throughout project creator (previously some public classes were documented and some not)

Note: if this does solve the issue for high dpi screens, then similar fixes would be needed for the main MoBIE UI etc that also show these issues

@K-Meech K-Meech requested a review from tischi August 3, 2023 13:25
@tischi
Copy link
Contributor

tischi commented Aug 11, 2023

Thanks a lot @K-Meech !!

@tischi tischi merged commit fea2f33 into mobie:develop Aug 11, 2023
1 check passed
@imagejan imagejan mentioned this pull request Oct 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tischi tischi Awaiting requested review from tischi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@K-Meech @tischi