Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] CarbonIntensityProvider and ElectricityMaps implementation #129

Merged
merged 11 commits into from
Oct 5, 2024
Merged

[Feat] CarbonIntensityProvider and ElectricityMaps implementation #129

merged 11 commits into from
Oct 5, 2024

Conversation

danielhou0515
Copy link
Collaborator

@danielhou0515 danielhou0515 commented Sep 29, 2024 •
edited by jaywonchung
Loading

Created abstract class for fetch carbon intensity. Added class that inherits from abstract class and support fetching with ElectricityMaps API.

Added Tests:

  • Test carbon fetching
  • Test exceptions in fetching and location detecting

See also: #53

jaywonchung
jaywonchung requested changes Sep 29, 2024
View reviewed changes
Copy link
Member

@jaywonchung jaywonchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! Thanks for the tests as well. I've left some suggestions and questions.

tests/carbon/test_electricity_maps_carbon_intensity_provider.py Outdated Show resolved Hide resolved
tests/carbon/test_electricity_maps_carbon_intensity_provider.py Outdated Show resolved Hide resolved
zeus/carbon/__init__.py Outdated Show resolved Hide resolved
zeus/carbon/__init__.py Outdated Show resolved Hide resolved
zeus/carbon/__init__.py Outdated Show resolved Hide resolved
zeus/carbon/electricity_maps_carbon_intensity_provider.py Outdated Show resolved Hide resolved
zeus/carbon/electricity_maps_carbon_intensity_provider.py Outdated Show resolved Hide resolved
zeus/carbon/electricity_maps_carbon_intensity_provider.py Outdated Show resolved Hide resolved
zeus/carbon/electricity_maps_carbon_intensity_provider.py Outdated Show resolved Hide resolved
zeus/carbon/carbon_intensity_provider.py Outdated Show resolved Hide resolved
@jaywonchung jaywonchung changed the title implemented abstract class for carbon intensity provider as well as ElectrictyMaps carbon intensity provider class [Feat] CarbonIntensityProvider and ElectricityMaps implementation Sep 29, 2024
jaywonchung
jaywonchung reviewed Sep 30, 2024
View reviewed changes
zeus/carbon/carbon.py Outdated Show resolved Hide resolved
jaywonchung
jaywonchung reviewed Sep 30, 2024
View reviewed changes
zeus/carbon/carbon.py Outdated Show resolved Hide resolved
jaywonchung
jaywonchung reviewed Sep 30, 2024
View reviewed changes
zeus/carbon/carbon.py Outdated Show resolved Hide resolved
jaywonchung
jaywonchung reviewed Sep 30, 2024
View reviewed changes
zeus/carbon/carbon.py Outdated Show resolved Hide resolved
@danielhou0515
Copy link
Collaborator Author

hahaha nice commit msg

@jaywonchung
Copy link
Member

LGTM, thanks @danielhou0515!!

@jaywonchung jaywonchung merged commit 86fe1a8 into master Oct 5, 2024
3 checks passed
@jaywonchung jaywonchung deleted the carbon_intensity branch October 5, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaywonchung jaywonchung Awaiting requested review from jaywonchung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielhou0515 @jaywonchung