-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failed renaming due to blocking references (exclude from renaming) #385
base: master
Are you sure you want to change the base?
Fix failed renaming due to blocking references (exclude from renaming) #385
Conversation
✅ Build ConfuserEx 829 completed (commit b4a38a059e by @KvanTTT) |
This is very likely just fixing a symptom and not the actual issue. It relies on the entire structure being in a state that is correctly renamed for the runtime in that state, but this isn't guarantied. From the classes/methods listed in the error message, it's not possible to identify the actual problem? It's very likely related to the inheritance structure in that case. |
I'll try to explore more, but later. |
Consider switching the PR to draft for the time being. |
BTW, I think symptoms fixing is better than not fixing them. At least output assembly will work if the first option is applied. |
The thing with this change is, that this is unlikely to work in many cases. The place where the obfuscation is interrupted in this case is at the point where parts of the structure that needs to be renamed as a whole, is already renamed. @KvanTTT: Your issue is still present after #425 has been merged? |
Unfortunately not. The same error that I've already described. |
The property not being renamed anymore is the expected result of the change. The fact that you are still seeing an error, points to some part of the inheritance structure still being renamed. |
Thank you for pointing out at Also, I've noticed there is something strange with |
When you say you "can't reproduce it". You mean that you can't extract an minimal example to show the issue or that you can't reproduce the issue anymore in your production code? Bit confused about this one 😉 |
The first one, extract a minimal example. Sure I can reproduce it on production since the exception exists 😊 |
Fix #379