testable for seq and contramap (for testable) #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samoht
reviewed
Sep 23, 2024
src/alcotest-engine/test.mli
Outdated
| @@ -107,6 +110,10 @@ val neg : 'a testable -> 'a testable | |||
| (** [neg t] is [t]'s negation: it is [true] when [t] is [false] and it is | |||
| [false] when [t] is [true]. *) | |||
|
|
|||
| val contramap : ('b -> 'a) -> 'a testable -> 'b testable | |||
There was a problem hiding this comment.
Do you mind naming this map -- even if it doesn't follow the theory, that's what more users would expect :p
There was a problem hiding this comment.
What do you think about keeping the Fmt convention by calling it using? (Because I find that calling it map makes reading its signature ... complicated).
There was a problem hiding this comment.
Hm, btw you are right, map works well, fixed on 415abb4
There was a problem hiding this comment.
using could work too - no strong opinion between map and using
|
Thanks that looks like a great addition! LGTM apart questions on names (the most difficult questions, as usual) |
MisterDA
requested changes
Sep 23, 2024
MisterDA
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
seq(to produces'a Seq.t testable) Because theSeq.ttype has become very common in the standard librarycontramapwhich allows you to go from an'a testableto a'b testablegiving a function fromb -> 'a(because a testable is a contravariant functor). I have often found the function useful for implementing testables quickly when there is a trivial transformation.