Support for building on native windows with cmake #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nega0
reviewed
Mar 26, 2024
There was a problem hiding this comment.
i'd use #ifndef _WIN32 etc. instead here. gettimeofday() is in sys/time.h on macOS too
There was a problem hiding this comment.
Are you sure you reviewed the complete diff? I am using #ifndef WINDOWS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to support natively building on windows via cmake.
Currently, a debug and release build should work on a windows machine with the required dependencies built from source with cmake. The only external dependency that has to be manually installed is OpenAL.
On top of that, multiple instances of undefined behavior and/or unportable code were fixed.
The cmake option ENABLE_STEAMWORKS was also added and building without steamworks is supported.