feat: Adds kiota authentication dependency into compilation classpath #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrueastman
approved these changes
Sep 3, 2024
|
baywet
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expose Kiota auth
ObservabilityOptionsin the public API of this package meaning we should add it to the compile classpath as anapidependency.Currently, the kiota-auth module is declared as a runtime dependency meaning customers have to take a direct dependency on it.
mavenprojects as in the linked issue currently fail with a compilation error.gradleseems to add all dependencies to the compilation classpath.closes microsoftgraph/msgraph-sdk-java#1942