Skip to content

Commit

Permalink
Merge branch 'main' into don/issue15987
Browse files Browse the repository at this point in the history
  • Loading branch information
DonJayamanne authored Oct 30, 2024
2 parents bbdf9d5 + 379229a commit ae8f8e3
Show file tree
Hide file tree
Showing 9 changed files with 10 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
- 'release-*'

env:
NODE_VERSION: 18.17.1
NODE_VERSION: 20.18.0
PYTHON_VERSION: '3.10' # YML treats 3.10 the number as 3.1, so quotes around 3.10
# Force a path with spaces and to test extension works in these scenarios
# Unicode characters are causing 2.7 failures so skip that for now.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
- release*

env:
NODE_VERSION: 18.17.1
NODE_VERSION: 20.18.0
PYTHON_VERSION: '3.10' # YML treats 3.10 the number as 3.1, so quotes around 3.10
MOCHA_REPORTER_JUNIT: true # Use the mocha-multi-reporters and send output to both console (spec) and JUnit (mocha-junit-reporter). Also enables a reporter which exits the process running the tests if it haven't already.
ARTIFACT_NAME_VSIX: ms-python-insiders-vsix
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18.17.1
v20.18.0
2 changes: 1 addition & 1 deletion build/azure-pipeline.pre-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ extends:
buildSteps:
- task: NodeTool@0
inputs:
versionSpec: '18.17.1'
versionSpec: '20.18.0'
displayName: Select Node version

- task: UsePythonVersion@0
Expand Down
2 changes: 1 addition & 1 deletion build/azure-pipeline.stable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ extends:
buildSteps:
- task: NodeTool@0
inputs:
versionSpec: '18.17.1'
versionSpec: '20.18.0'
displayName: Select Node version

- task: UsePythonVersion@0
Expand Down
6 changes: 3 additions & 3 deletions build/azure-pipelines/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,13 @@ extends:
testPlatforms:
- name: Linux
nodeVersions:
- 18.17.1
- 20.18.0
- name: MacOS
nodeVersions:
- 18.17.1
- 20.18.0
- name: Windows
nodeVersions:
- 18.17.1
- 20.18.0
testSteps:
- template: /build/azure-pipelines/templates/test-steps.yml@self
parameters:
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
"quickPickItemTooltip",
"terminalDataWriteEvent",
"terminalExecuteCommandEvent",
"contribIssueReporter",
"codeActionAI",
"notebookReplDocument",
"notebookVariableProvider"
Expand Down
2 changes: 1 addition & 1 deletion pythonExtensionApi/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pythonExtensionApi/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"main": "./out/main.js",
"types": "./out/main.d.ts",
"engines": {
"node": ">=18.17.1",
"node": ">=20.18.0",
"vscode": "^1.93.0"
},
"license": "MIT",
Expand Down

0 comments on commit ae8f8e3

Please sign in to comment.