Skip to content

Commit

Permalink
fix: tag non-stable settings with new system (#24287)
Browse files Browse the repository at this point in the history
This PR changes some setting tags as follows:

- Remove the experimental tag from the `python.missingPackage.severity`
setting considering the setting does not seem to be experimental and
that the setting does not seem to be part of any experiment.
- Add the onExP tag onto the `python.locator` setting considering the
setting is both experimental (based on its description) and part of an
experiment.
- Change the experimental tag to preview for
`python.terminal.shellIntegration.enabled`, considering it is a
non-stable setting that does not seem to be part of an experiment.
- Add the onExP tag to `python.REPL.sendToNativeREPL` considering it is
part of an experiment.
  • Loading branch information
rzhao271 authored Oct 11, 2024
1 parent 041be0d commit 9be9308
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 9 deletions.
13 changes: 6 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -582,10 +582,7 @@
"Warning"
],
"scope": "resource",
"type": "string",
"tags": [
"experimental"
]
"type": "string"
},
"python.locator": {
"default": "js",
Expand All @@ -595,7 +592,8 @@
"native"
],
"tags": [
"experimental"
"experimental",
"onExP"
],
"scope": "machine",
"type": "string"
Expand Down Expand Up @@ -662,7 +660,7 @@
"scope": "resource",
"type": "boolean",
"tags": [
"experimental"
"preview"
]
},
"python.REPL.enableREPLSmartSend": {
Expand All @@ -677,7 +675,8 @@
"scope": "resource",
"type": "boolean",
"tags": [
"experimental"
"experimental",
"onExP"
]
},
"python.REPL.provideVariables": {
Expand Down
4 changes: 2 additions & 2 deletions package.nls.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@
"python.diagnostics.sourceMapsEnabled.description": "Enable source map support for meaningful stack traces in error logs.",
"python.envFile.description": "Absolute path to a file containing environment variable definitions.",
"python.experiments.enabled.description": "Enables A/B tests experiments in the Python extension. If enabled, you may get included in proposed enhancements and/or features.",
"python.experiments.optInto.description": "List of experiment to opt into. If empty, user is assigned the default experiment groups. See [here](https://github.com/microsoft/vscode-python/wiki/AB-Experiments) for more details.",
"python.experiments.optOutFrom.description": "List of experiment to opt out of. If empty, user is assigned the default experiment groups. See [here](https://github.com/microsoft/vscode-python/wiki/AB-Experiments) for more details.",
"python.experiments.optInto.description": "List of experiments to opt into. If empty, user is assigned the default experiment groups. See [here](https://github.com/microsoft/vscode-python/wiki/AB-Experiments) for more details.",
"python.experiments.optOutFrom.description": "List of experiments to opt out of. If empty, user is assigned the default experiment groups. See [here](https://github.com/microsoft/vscode-python/wiki/AB-Experiments) for more details.",
"python.experiments.All.description": "Combined list of all experiments.",
"python.experiments.pythonSurveyNotification.description": "Denotes the Python Survey Notification experiment.",
"python.experiments.pythonPromptNewToolsExt.description": "Denotes the Python Prompt New Tools Extension experiment.",
Expand Down

0 comments on commit 9be9308

Please sign in to comment.