feat: implement wasm inline functions #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor4312
force-pushed
the
connor4312/wasm-15
branch
from
bb09bec
to
ce695e7
Compare
connor4312
force-pushed
the
connor4312/wasm-15
branch
from
ce695e7
to
2cf86cb
Compare
connor4312
changed the title
roblourens
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final part of the initial DWARF debugging work. It implements support for dealing with inlined function calls, such that inline functions appear as normal in the stack, and stepping works. This also improves stepping overall, such that stepping goes between statements rather than assembly instructions.
The linked docs briefly explain how inlined functions work in their API. The largest chunk of code in this PR is refactoring the stacktrace functionality to support these 'fake' callframes.