Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prompt to install extension on wasm step #1807

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

connor4312
Copy link
Member

This is part 4 in a stacked PR. This will get merged down into a single PR after all of them are reviewed

This prompts to install the DWARF debugger the first time a user steps into a relevant file. If the debugger is running outside of VS Code (we ship a standalone DAP server that neovim and a few other people use) it just prints a console message asking to install the Node module. For VS Code, it's show as a notification to install the extension that exports the API.

We do this because the DWARF debugging component is about 12MB alone which is not something we want to ship out of the box in VS Code.

* implement inlined method handling and improve stepping

* update tests
@connor4312 connor4312 merged commit ccabc8c into connor4312/wasm-13 Sep 20, 2023
2 of 8 checks passed
@connor4312 connor4312 deleted the connor4312/wasm-14 branch September 20, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants