feat: prompt to install extension on wasm step #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
approved these changes
Sep 20, 2023
* implement inlined method handling and improve stepping * update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prompts to install the DWARF debugger the first time a user steps into a relevant file. If the debugger is running outside of VS Code (we ship a standalone DAP server that neovim and a few other people use) it just prints a console message asking to install the Node module. For VS Code, it's show as a notification to install the extension that exports the API.
We do this because the DWARF debugging component is about 12MB alone which is not something we want to ship out of the box in VS Code.