feat: make wasm variable store work #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
approved these changes
Sep 20, 2023
* implement inlined method handling and improve stepping * update tests
feat: prompt to install extension on wasm step
feat: make wasm inline breakpoints work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the "variables" view in WebAssembly It introduces new types in the VariableStore that handle WebAssembly (though this is tweaked and cleaned up slightly in a later stack.) The actual call is pretty simple,
listVariablesInScopeon the worker lists variables, and then we can get their properties.Also, this PR moves the debugger to have a strong preference for setting breakpoints by URL. This makes breakpoints behave better on reload, which is important because there is no instrumentation pause for WebAssembly. Having looked a little in the Chrome debugger, they actually never set breakpoints by script ID any more, so this follows in their footsteps.