Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vincentlaucsb-csv-parser] Fix gcov linking errors on linux. #41716

Merged

Conversation

aluaces
Copy link
Contributor

@aluaces aluaces commented Oct 22, 2024

On linux programs using this port in debug mode fail because the library is being compiled with coverage rigging.

This patch disables that unused instrumentation.

@WangWeiLin-MV WangWeiLin-MV changed the title Fix gcov linking errors on linux. [vincentlaucsb-csv-parser] Fix gcov linking errors on linux. Oct 23, 2024
@WangWeiLin-MV WangWeiLin-MV added the category:port-bug The issue is with a library, which is something the port should already support label Oct 23, 2024
@WangWeiLin-MV
Copy link
Contributor

On linux programs using this port in debug mode fail because the library is being compiled with coverage rigging.

As this problem would also exist in upstream, so it is recommended to contribute this patch upstream.

Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to wait for upstream.

@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label Oct 23, 2024
@data-queue data-queue merged commit 9f5925e into microsoft:master Oct 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants