[scripts] Update msys2 packages #41665
Open
+118
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We must keep |
Mengna-Li
added
the
category:tool-update
dg0yt
commented
Oct 23, 2024
Comment on lines
+253
to
+258
| "${path_to_root}/clangarm64/lib/pkgconfig" | ||
| "${path_to_root}/clang64/lib/pkgconfig" | ||
| "${path_to_root}/mingw32/lib/pkgconfig" | ||
| "${path_to_root}/mingw64/lib/pkgconfig" | ||
| "${path_to_root}/ucrt64/lib/pkgconfig" | ||
| "${path_to_root}/usr/lib/pkgconfig" |
There was a problem hiding this comment.
Note: These dirs are not required for the tools (in particular pkgconf) to work. When present, they may change what typical CMake Find modules consider as hints for header and lib search. This is not desirable for the use cases of vcpkg_acquire_msys.
Mengna-Li
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And prevent pkgconfig hints from the msys2 installation.