[scnlib] fix SCN_HAS_STD_REGEX_MULTILINE marco #41653
Open
+25
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuehua
changed the title
Mengna-Li
added
the
category:port-bug
Mengna-Li
approved these changes
Oct 21, 2024
data-queue
reviewed
Oct 22, 2024
|
|
||
| // Detect std::regex_constants::multiline: | ||
| // libc++ 15 and later, or libstdc++ 11.4 or later | ||
| -// (2021-09-29 is the date of the commit introducing `multiline`, |
There was a problem hiding this comment.
Can you submit this patch upstream?
There was a problem hiding this comment.
already submit to upstream eliaskosunen/scnlib#130
Mengna-Li
added
depends:upstream-changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://godbolt.org/z/EhsWsMvEK
ports/scnlib/fix-SCN_HAS_STD_REGEX_MULTILINE-marco.patch is needed otherwise this port can't build successfully use gcc11.3, so add it back.