Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rtmidi] update to 3.0.0 #41633

Merged
merged 8 commits into from
Oct 23, 2024
Merged

[rtmidi] update to 3.0.0 #41633

merged 8 commits into from
Oct 23, 2024

Conversation

jiayuehua
Copy link
Contributor

@jiayuehua jiayuehua commented Oct 18, 2024

also add android fail to ci

@jiayuehua jiayuehua marked this pull request as draft October 18, 2024 06:01
@MonicaLiu0311 MonicaLiu0311 added the category:port-update The issue is with a library, which is requesting update new revision label Oct 18, 2024
@jiayuehua
Copy link
Contributor Author

/mnt/vcpkg-ci/b/rtmidi/src/6.0.0-ef3f47c55b.clean/RtMidi.cpp:4957:5: error: 'AMidiOutputPort_open' is unavailable: introduced in Android 29
    AMidiOutputPort_open(midiIn->receiveDevice, 0, &midiIn->midiOutputPort);
    ^
/android-ndk-r26d/toolchains/llvm/prebuilt/linux-x86_64/sysroot/usr/include/amidi/AMidi.h:249:26: note: 'AMidiOutputPort_open' has been explicitly marked unavailable here
media_status_t AMIDI_API AMidiOutputPort_open(const AMidiDevice *device, int32_t portNumber,
                         ^
/mnt/vcpkg-ci/b/rtmidi/src/6.0.0-ef3f47c55b.clean/RtMidi.cpp:5083:3: error: 'AMidiDevice_release' is unavailable: introduced in Android 29
  AMidiDevice_release(receiveDevice);
  ^
/android-ndk-r26d/toolchains/llvm/prebuilt/linux-x86_64/sysroot/usr/include/amidi/AMidi.h:168:26: note: 'AMidiDevice_release' has been explicitly marked unavailable here
media_status_t AMIDI_API AMidiDevice_release(const AMidiDevice *midiDevice) __INTRODUCED_IN(29);
                         ^
/mnt/vcpkg-ci/b/rtmidi/src/6.0.0-ef3f47c55b.clean/RtMidi.cpp:5113:35: error: 'AMidiOutputPort_receive' is unavailable: introduced in Android 29
    ssize_t numMessagesReceived = AMidiOutputPort_receive(
                                  ^
/android-ndk-r26d/toolchains/llvm/prebuilt/linux-x86_64/sysroot/usr/include/amidi/AMidi.h:277:19: note: 'AMidiOutputPort_receive' has been explicitly marked unavailable here
ssize_t AMIDI_API AMidiOutputPort_receive(const AMidiOutputPort *outputPort, int32_t *opcodePtr,
                  ^
/mnt/vcpkg-ci/b/rtmidi/src/6.0.0-ef3f47c55b.clean/RtMidi.cpp:5246:3: error: 'AMidiDevice_release' is unavailable: introduced in Android 29
  AMidiDevice_release(sendDevice);
  ^
/android-ndk-r26d/toolchains/llvm/prebuilt/linux-x86_64/sysroot/usr/include/amidi/AMidi.h:168:26: note: 'AMidiDevice_release' has been explicitly marked unavailable here
media_status_t AMIDI_API AMidiDevice_release(const AMidiDevice *midiDevice) __INTRODUCED_IN(29);
                         ^
/mnt/vcpkg-ci/b/rtmidi/src/6.0.0-ef3f47c55b.clean/RtMidi.cpp:5261:3: error: 'AMidiInputPort_send' is unavailable: introduced in Android 29
  AMidiInputPort_send(midiInputPort, (uint8_t*)message, size);
  ^
/android-ndk-r26d/toolchains/llvm/prebuilt/linux-x86_64/sysroot/usr/include/amidi/AMidi.h:309:19: note: 'AMidiInputPort_send' has been explicitly marked unavailable here
ssize_t AMIDI_API AMidiInputPort_send(const AMidiInputPort *inputPort, const uint8_t *buffer,
                  ^

@jiayuehua jiayuehua marked this pull request as ready for review October 22, 2024 04:04
@jiayuehua
Copy link
Contributor Author

@MonicaLiu0311 could you please help run ci again?

@MonicaLiu0311
Copy link
Contributor

@MonicaLiu0311 could you please help run ci again?

Done

@MonicaLiu0311
Copy link
Contributor

All features are tested successfully in the following triplet:

x64-linux

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Oct 23, 2024
@data-queue data-queue merged commit 31554ea into microsoft:master Oct 23, 2024
16 checks passed
@jiayuehua jiayuehua deleted the rtmidi branch October 23, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants