[opencv] update to 4.9

[cenit]

Fixes #41418
Fixes #41250
Fixes #41094
Fixes #41038
Fixes #40680
Fixes #40568
Fixes #40393
Fixes #40406
Fixes #39884
Fixes #39835
Fixes #39651
Fixes #39454
Fixes #39224
Fixes #38321
Fixes #36771
Fixes #36093
Fixes #36009
Fixes #35937
Fixes #34559
Fixes #34279
Fixes #33742
Fixes #32228
Fixes #17850
Fixes #13120
Fixes #4937

Depending on #39703 (need to remove ffmpeg from ci.baseline here after that PR acceptance)

• Changes comply with the maintainer guide.
• SHA512s are updated for each updated download.
• The "supports" clause reflects platforms that may be fixed by this new version.
• Any fixed CI baseline entries are removed from that file.
• Any patches that are no longer applied are deleted from the port's directory.
• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
• Only one version is added to each modified port's versions file.

[BillyONeal]

/azp run

[BillyONeal]

Rerunning due to network mistake.

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[BillyONeal]

@JavierMatosD Do you remember why you tagged this team review?

[russelltg]

I think the string(APPEND DEPS_STRING "\nfind_dependency(CUDA)") need to be string(APPEND DEPS_STRING "\nfind_dependency(CUDAToolkit)") now that we pass ENABLE_CUDA_FIRST_CLASS_LANGUAGE

[cenit]

merged with master to fix file conflicts (pcl patch was added also to a more recent PR already accepted)

[cenit]

I think the string(APPEND DEPS_STRING "\nfind_dependency(CUDA)") need to be string(APPEND DEPS_STRING "\nfind_dependency(CUDAToolkit)") now that we pass ENABLE_CUDA_FIRST_CLASS_LANGUAGE

good catch. Done, thanks.

[cenit]

I think the string(APPEND DEPS_STRING "\nfind_dependency(CUDA)") need to be string(APPEND DEPS_STRING "\nfind_dependency(CUDAToolkit)") now that we pass ENABLE_CUDA_FIRST_CLASS_LANGUAGE

good catch. Done, thanks.

if CUDA feature is enable, this is already appearing in OpenCVConfig.cmake:

# Version Compute Capability from which OpenCV has been compiled is remembered
set(OpenCV_COMPUTE_CAPABILITIES "50-real;52-real;60-real;61-real;70-real;75-real;80-real;86-real;89-real;90-real;90-virtual")

set(OpenCV_CUDA_VERSION "12.6.20")
set(OpenCV_USE_CUBLAS   "1")
set(OpenCV_USE_CUFFT    "1")
set(OpenCV_USE_NVCUVID  "")
set(OpenCV_USE_NVCUVENC "")
set(OpenCV_CUDNN_VERSION    "")
set(OpenCV_USE_CUDNN        "")
set(ENABLE_CUDA_FIRST_CLASS_LANGUAGE  ON)

if(NOT CUDAToolkit_FOUND)
  if(NOT CMAKE_VERSION VERSION_LESS 3.18)
    if(UNIX AND NOT CMAKE_CUDA_COMPILER AND NOT CUDAToolkit_ROOT)
      message(STATUS "Checking for CUDAToolkit in default location (/usr/local/cuda)")
      set(CUDA_PATH "/usr/local/cuda" CACHE INTERNAL "")
      set(ENV{CUDA_PATH} ${CUDA_PATH})
    endif()
    find_package(CUDAToolkit ${OpenCV_CUDA_VERSION} EXACT REQUIRED)
  else()
    message(FATAL_ERROR "Using OpenCV compiled with CUDA as first class language requires CMake \>= 3.18.")
  endif()
else()
  if(CUDAToolkit_FOUND)
    set(CUDA_VERSION_STRING ${CUDAToolkit_VERSION})
  endif()
  if(NOT CUDA_VERSION_STRING VERSION_EQUAL OpenCV_CUDA_VERSION)
      message(FATAL_ERROR "OpenCV library was compiled with CUDA ${OpenCV_CUDA_VERSION} support. Please, use the same version or rebuild OpenCV with CUDA ${CUDA_VERSION_STRING}")
  endif()
endif()

so the find_dependency(CUDA) was unnecessary with the new architecture, but also the find_dependency(CUDAToolkit) is too!

I have removed it from OpenCV 4 port

[cenit]

i think that regression on vcpkg-ci-msys2 is not due to this PR

[dg0yt]

i think that regression on vcpkg-ci-msys2 is not due to this PR

No, it isn't, and there are PRs for that.

[dg0yt]

i think that regression on vcpkg-ci-msys2 is not due to this PR

No, it isn't, and there are PRs for that.

Merged. (#41691)

[cenit]

@JavierMatosD Do you remember why you tagged this team review?

any news?