Update pyproject.toml #22507
Open
Update pyproject.toml #22507
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianleiwu
previously approved these changes
Oct 21, 2024
|
Black dosen't support py313. |
snnn
reviewed
Oct 21, 2024
.github/workflows/lint.yml
Outdated
| @@ -43,7 +43,7 @@ jobs: | |||
| uses: actions/setup-python@v5 | |||
| with: | |||
| # Version range or exact version of Python to use, using SemVer's version range syntax. Reads from .python-version if unset. | |||
| python-version: "3.10" | |||
| python-version: "3.12" | |||
There was a problem hiding this comment.
Have you tried to change it to 3.13? Did it work?
snnn
reviewed
Oct 21, 2024
pyproject.toml
Outdated
| @@ -2,7 +2,7 @@ | |||
| line-length = 120 | |||
| # NOTE: Do not extend the exclude list. Edit .lintrunner.toml instead | |||
| extend-exclude = "cmake|onnxruntime/core/flatbuffers/" | |||
| target-version = ["py37", "py38", "py39", "py310", "py311"] | |||
| target-version = ["py310","py311","py312","py313"] | |||
There was a problem hiding this comment.
If py313 doesn't work, we don't have to enable it now.
tianleiwu
approved these changes
Oct 22, 2024
|
Why the linter runner found so many issues? |
|
@justinchuby , please help review. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update pyproject.toml and remove outdate python version support. Adding python313.