Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PGO.compile.props to address a xfgcheck issue #8792

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

alexlamtest
Copy link
Contributor

Description

A link time flag "/debugtype:cv,fixup" is added in an attempt to address a xfgcheck6 error reported by static analysis ).

Motivation and Context

This PR aims to address b#45848850.

How Has This Been Tested?

No existing test can verify this change. The E2E test to is observe that static analysis no longer emits the xfgcheck6 error after this PR has merged.

Screenshots (if appropriate):

A link time flag is added in an attempt to address a xfgcheck6 error.
@microsoft-github-policy-service microsoft-github-policy-service bot added the needs-triage Issue needs to be triaged by the area owners label Aug 29, 2023
@bpulliam bpulliam removed the needs-triage Issue needs to be triaged by the area owners label Aug 29, 2023
@alexlamtest
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 8792 in repo microsoft/microsoft-ui-xaml

Copy link
Contributor

@codendone codendone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bpulliam
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@evelynwu-msft evelynwu-msft merged commit df08001 into microsoft:main Aug 31, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants