-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PersonPicture update: Overwriteable properties #6655
Conversation
Properties can now be overwritten (Background, BorderBrush and BorderThickness)
Properties can now be overwritten (Background, BorderBrush and BorderThickness)
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@jp-weber the failing VisualVerification tests show the person picture properties changing. I thought this change would have no visual impact by default. Can you explain the diff? |
fixed wrong BorderBrush
@StephenLPeters I see the problem, I have overwritten the BorderBrush in PersonPicture.xaml with the value from PersonPicture_v1.xaml. Now it is correct. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@bkudiess the UnitTest VerifyPersonPictureVisualTree has failed. I have no idea what the reason is. ##[error]ApiTests.PersonPictureTests.VerifyPersonPictureVisualTree: |
Push |
@StephenLPeters @bkudiess Any chance this could be merged soon? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Thank you @ojhad, I have created a cherry pick from your commit. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@jp-weber Looks like the script didn't update the visual verification files properly and that test is still failing. Can you delete the |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@ojhad |
Description
Make properties of PersonPicture overwriteable. Solves #6654
Motivation and Context
How Has This Been Tested?
Only in debug mode. No UnitTest.
Screenshots (if appropriate):