Popup placement properties API spec #4905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to account when its popup is windowed.
Fixing typo.
Updating "AnchorElement" to be "Target" instead.
Updating Target to be PlacementTarget instead.
ghost
added
the
llongley
force-pushed
the
user/llongley/PopupPlacementAPISpec
branch
from
624ba45
to
9513b70
Compare
…tMonitorCheck' into user/llongley/PopupPlacementAPISpec
…ation into account when its popup is windowed." This reverts commit 564a099.
…com/microsoft/microsoft-ui-xaml into user/llongley/PopupPlacementAPISpec
oldnewthing
reviewed
Apr 27, 2021
| ## Popup.PlacementTarget property | ||
|
|
||
| Use this property to describe which element the `Popup` should be positioned relative to. | ||
| Defaults to `null`. |
There was a problem hiding this comment.
Note that the addition of this property will require some reworking of the existing Popup documentation that talks about placement.
In fact, we forgot to update the Popup documentation when we added ShouldConstrainToRootBounds. The Popup documentation still says right there in the first sentence, "Displays content on top of existing content, within the bounds of the application window" which is no longer true if ShouldConstrainToRootBounds is false.
ranjeshj
added
area-Popup
SpecInReview
and removed
needs-triage
Co-authored-by: Raymond Chen <oldnewthing@users.noreply.github.com>
Changed PlacementTarget from UIElement to FrameworkElement - this doesn't change the use cases any, and we need the layout properties on FrameworkElement.
Updating with final API names.
|
@llongley is this something that we are still planning on doing? If not we should close out this PR. |
ranjeshj
approved these changes
Aug 7, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
microsoft-github-policy-service
bot
added
the
needs-triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a spec for proposed new APIs on Popup that will add the ability to position a Popup relative to another element:
https://github.com/microsoft/microsoft-ui-xaml/blob/user/llongley/PopupPlacementAPISpec/specs/Popup-AdditionalLayoutProperties-Spec.md