Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup placement properties API spec #4905

Merged
merged 26 commits into from
Aug 8, 2023
Merged

Conversation

llongley
Copy link
Member

This adds a spec for proposed new APIs on Popup that will add the ability to position a Popup relative to another element:

https://github.com/microsoft/microsoft-ui-xaml/blob/user/llongley/PopupPlacementAPISpec/specs/Popup-AdditionalLayoutProperties-Spec.md

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Apr 26, 2021
@llongley llongley force-pushed the user/llongley/PopupPlacementAPISpec branch from 624ba45 to 9513b70 Compare April 26, 2021 23:34
specs/Popup-AdditionalLayoutProperties-Spec.md Outdated Show resolved Hide resolved
## Popup.PlacementTarget property

Use this property to describe which element the `Popup` should be positioned relative to.
Defaults to `null`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the addition of this property will require some reworking of the existing Popup documentation that talks about placement.

In fact, we forgot to update the Popup documentation when we added ShouldConstrainToRootBounds. The Popup documentation still says right there in the first sentence, "Displays content on top of existing content, within the bounds of the application window" which is no longer true if ShouldConstrainToRootBounds is false.

specs/Popup-AdditionalLayoutProperties-Spec.md Outdated Show resolved Hide resolved
specs/Popup-AdditionalLayoutProperties-Spec.md Outdated Show resolved Hide resolved
specs/Popup-AdditionalLayoutProperties-Spec.md Outdated Show resolved Hide resolved
specs/Popup-AdditionalLayoutProperties-Spec.md Outdated Show resolved Hide resolved
specs/Popup-AdditionalLayoutProperties-Spec.md Outdated Show resolved Hide resolved
@ranjeshj ranjeshj added area-Popup SpecInReview and removed needs-triage Issue needs to be triaged by the area owners labels Apr 27, 2021
@ranjeshj ranjeshj added the team-Controls Issue for the Controls team label Apr 27, 2021
llongley and others added 4 commits April 28, 2021 12:10
Co-authored-by: Raymond Chen <oldnewthing@users.noreply.github.com>
Changed PlacementTarget from UIElement to FrameworkElement - this doesn't change the use cases any, and we need the layout properties on FrameworkElement.
Updating with final API names.
@kmahone
Copy link
Member

kmahone commented May 23, 2022

@llongley is this something that we are still planning on doing? If not we should close out this PR.

@llongley
Copy link
Member Author

llongley commented Aug 7, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kmahone kmahone closed this Aug 8, 2023
@kmahone kmahone reopened this Aug 8, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the needs-triage Issue needs to be triaged by the area owners label Aug 8, 2023
@llongley llongley merged commit ad5b491 into main Aug 8, 2023
4 checks passed
@llongley llongley deleted the user/llongley/PopupPlacementAPISpec branch August 8, 2023 22:38
@bpulliam bpulliam removed the needs-triage Issue needs to be triaged by the area owners label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants