-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Vs-Code functionality to generate http snippets #5268
base: main
Are you sure you want to change the base?
Conversation
@@ -242,6 +243,77 @@ export async function activate( | |||
} | |||
} | |||
), | |||
registerCommandWithTelemetry(reporter, | |||
`${treeViewId}.generateHttpSnippet`, | |||
async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is new code, and there's planned refactoring, it would be safe to move the functionality of this command out of the extension.ts file.
The command can follow the abstract command class as defined in this PR #5160
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thewahome I can wait for yours to get merged first to avoid increasing the conflict delta, if we both refactor at the same time, the conflict will be greater down the line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is likely not going to get merged because of how much the code has changed since freezing it. It's going to be maintained as a reference.
Quality Gate failedFailed conditions |
No description provided.