Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add instance and init to backing store factory singleton #252

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add instance and init to backing store factory singleton #252

wants to merge 1 commit into from

Conversation

shemogumbe
Copy link

Overview

Brief description of what this PR does, and why it is needed.

Related Issue

Fixes # (issue)

Demo

Optional. Screenshots, curl examples, etc.

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • How to test this PR
  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as bundling scripts, restarting services, etc.
  • Include test case, and expected output

@shemogumbe shemogumbe requested a review from a team as a code owner March 27, 2024 11:01
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

andrueastman
andrueastman reviewed Mar 27, 2024
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance we can double the check the failing CI? The PR will also need a changelog entry/version bump.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman left review comments

@samwelkanda samwelkanda Awaiting requested review from samwelkanda

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
conflicting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shemogumbe @andrueastman