Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test #307

Closed
wants to merge 1 commit into from
Closed

test #307

wants to merge 1 commit into from

Conversation

thivy
Copy link
Contributor

@thivy thivy commented Feb 2, 2024

No description provided.

@thivy thivy closed this Feb 2, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 2, 2024
View reviewed changes
infra/resources.bicep Dismissed Show dismissed Hide dismissed
infra/resources.bicep



resource azureopenaivision 'Microsoft.CognitiveServices/accounts@2023-05-01' = {

Check failure

Code scanning / templateanalyzer

Use Managed Identity for Cogitive Services accounts. Error

Cognitive Services must authenticate to Azure resources such storage accounts. To authenticate to Azure resources, Cognitive Services can use managed identities.
Using Azure managed identities have the following benefits: You don't need to store or manage credentials.
Azure automatically generates tokens and performs rotation. You can use managed identities to authenticate to any Azure service that supports Azure AD authentication. Managed identities can be used without any additional cost.
infra/resources.bicep Dismissed Show dismissed Hide dismissed
infra/resources.bicep
@@ -383,4 +559,23 @@
}
}

// TODO: define good default Sku and settings for storage account
resource storage 'Microsoft.Storage/storageAccounts@2022-05-01' = {

Check failure

Code scanning / templateanalyzer

Storage Account minimum TLS version. Error

The minimum version of TLS that Azure Storage Accounts accept for blob storage is configurable. Older TLS versions are no longer considered secure by industry standards, such as PCI DSS.
Storage Accounts lets you disable outdated protocols and enforce TLS 1.2. By default, TLS 1.0, TLS 1.1, and TLS 1.2 is accepted.
infra/resources.bicep Dismissed Show dismissed Hide dismissed
infra/resources.bicep Dismissed Show dismissed Hide dismissed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thivy