refactor: improve visibilities #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinathsetty
reviewed
Apr 8, 2024
| @@ -58,9 +57,8 @@ harness = false | |||
| required-features = ["std"] | |||
|
|
|||
| [features] | |||
| default = ["std", "simd_backend"] | |||
There was a problem hiding this comment.
Is there a reason to remove this from the default features?
There was a problem hiding this comment.
That's because this feature was deprecated.
version 3.2.0 has feature simd_backend.
https://github.com/dalek-cryptography/curve25519-dalek/blob/3.2.0/Cargo.toml#L71
but version 4.1.1 doesn't have simd_backend.
https://github.com/dalek-cryptography/curve25519-dalek/blob/curve25519-4.1.1/curve25519-dalek/Cargo.toml#L65
srinathsetty
added a commit
that referenced
this pull request
Apr 11, 2024
This reverts commit f25d18a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there
I refactored some parts of polynomial operations.
I really like this way to deal with sparse polynomial so aligned other implementations with it.
I would appreciate it if you could confirm.
Thank you.