Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

javadoc: @RequestFilter Publisher<Optional<HttpResponse>> #11270

Open
wants to merge 2 commits into
base: 4.7.x
Choose a base branch
from
Open

javadoc: @RequestFilter Publisher<Optional<HttpResponse>> #11270

wants to merge 2 commits into from
+4 −1

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Oct 23, 2024

No description provided.

@sdelamo sdelamo requested a review from yawkat October 23, 2024 08:02
@yawkat
Copy link
Member

yawkat commented Oct 23, 2024

I don't think it is appropriate to add a special comment about Publisher<Optional<HttpResponse<?>>>, here. It is merely a special case of the other allowed return value types (void, null, HttpRequest, HttpResponse) wrapped in a Publisher, which is already mentioned in the javadoc. However the fact that Optional can replace a @Nullable T is not mentioned and should be added

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yawkat yawkat Awaiting requested review from yawkat

Assignees
No one assigned
Labels
type: docs
Projects
4.7.0 Release
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdelamo @yawkat