Changes needed for MINIMAL_CORE=3 ... #1288
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to remove even more unneeded extra fluff. Useful if compiling the library only for GSF playback, for instance.
|
I think having a flag DISABLE_VIDEO would be better than overloading MINIMAL_CORE. In fact, I wanted to branch out with feature flags to replace MINIMAL_CORE entirely. |
|
Alright, just let me know what you do settle on, since I don’t need video rendering for GSF playback, but it doesn’t get in the way, either, it just means more needs to be compiled into libmgba. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to remove even more unneeded extra fluff. Useful
if compiling the library only for GSF playback, for
instance.