Mutator set for is_open_tracking and is_click_tracking and Attribute Casting updated for all boolean values #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afrasiyabhaider
commented
Sep 16, 2024
•
afrasiyabhaider
commented
- The issue is in sendportal_campaigns table we have 2 columns is_open_tracking and is_click_tracking , it have value stored as 0, 1 but the expected value by function is true/false
- as per laravel https://laravel.com/docs/10.x/eloquent-mutators#attribute-casting
- Getting Argument Type Error in MessageTrackingOptions.php on line 35 sendportal#313
- The issue is in sendportal_campaigns table we have 2 columns is_open_tracking and is_click_tracking , it have value stored as 0, 1 but the expected value by function is true/false - mettle/sendportal#313
afrasiyabhaider
changed the title
|
@JonoB please review |
afrasiyabhaider
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.