Set Core Subject Thesarurus dates in udpate-fixed-info process to override default behavior in GeoNetwork using the current date #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rride default behavior in GeoNetwork using the current date. Fixes #308
ianwallen
reviewed
Apr 4, 2023
| @@ -955,6 +955,51 @@ | |||
| </xsl:copy> | |||
| </xsl:template> | |||
|
|
|||
| <!-- Fix the dates for the Core Subject Thesaurus --> | |||
There was a problem hiding this comment.
This seems to be a bug specifically to fix "Core Subject Thesaurus" Thesarurus
I would have expected a fix that would not change the Thesarurus date if a value already exists. Otherwise are we not going to have the same issue with the other thesaurus?
|
Sometimes, the thesaurus does have date in the thesaurus file which is not last modified date. We do need to ensure that "good" date is not wiped out. We probably need to do something on the Java server side to have a flag stating this is last modified date. Then HNAP xsl can recognize it and avoid the transformation. |
|
@josegar74 is this PR still required? I believe @wangf1122 's fix in PR #327 will resolve the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #308