Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Notification Sound Feature #185

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

birdpump
Copy link

This PR adds notification sounds to the Meshtastic web interface. It resolves #183. I added a notification sound that is played when a new message is sent to a connected node via a DM or channel. I have also added a bell icon on the sidebar that enables/disables the notification sound, and notifications are enabled by default. I can think of a few issues, such as the notification sound playing but there being no indication of where the new message is, so it may be a bit confusing if a lot of channels are displayed. Marking this PR as draft to get some feedback on the implementation. Please let me know if the logic checks out and is proper. I am relatively new to React.

@Hunter275 Hunter275 added the enhancement New feature or request label Jun 16, 2024
@Hunter275
Copy link
Member

Hunter275 commented Jun 16, 2024

@birdpump This works great in my testing.

The only thing I could think to add is a few different notification sounds and a setting to change them. Could be per channel or system wide.

@Hunter275 Hunter275 added help wanted Extra attention is needed minor change This is a minor change labels Jun 16, 2024
@smiba
Copy link

smiba commented Jun 23, 2024

Not sure if it already exists (but I can't see it in your commits and haven't dug into the code), but it would be nice if this could work together with the browser's notification channel to allow more native OS notifications. (Web Push)

@birdpump
Copy link
Author

Not sure if it already exists (but I can't see it in your commits and haven't dug into the code), but it would be nice if this could work together with the browser's notification channel to allow more native OS notifications. (Web Push)

I was planning on also adding web push when I get a chance, thanks for the suggestion.

@Hunter275
Copy link
Member

One issue with this is we need to make a notification sound, some discussion was had around various possibilities but nothing was decided.

If you're able and willing to create a notification sound and let Meshtastic use it let us know.

In the mean time we should find a sound we can use without license issues.

@Kealper
Copy link

Kealper commented Sep 28, 2024

Here's a simple notification sound I whipped together, if you like it, I can export it in whatever file format you'd need.
Meshtastic Notification.wav.gz

@Hunter275 Hunter275 marked this pull request as ready for review October 3, 2024 02:53
@birdpump
Copy link
Author

I should be able to get web push implemented this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed minor change This is a minor change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Notification sounds
4 participants