Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align terminology with iOS and Android Apps #168

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

davidlpower
Copy link
Contributor

@davidlpower davidlpower commented Mar 4, 2024

Align web client to use the same terminology for nodes. This is inline with both the Android and iOS Apps.

Primary Change

  • Changing peers to nodes.

Important

…s to nodes. This is inline with both the Android and iOS Apps.
@CLAassistant
Copy link

CLAassistant commented Mar 4, 2024

CLA assistant check
All committers have signed the CLA.

@tekstrand
Copy link

@sachaw could be cool to get this one merged.

@sachaw
Copy link
Member

sachaw commented Mar 11, 2024

Will do, however the class names that use the word peer have been overwritten with node, this is incorrect as it is used for styling.

@davidlpower
Copy link
Contributor Author

davidlpower commented Mar 11, 2024

Hi @sachaw - my goal was to remove the terminology peer from the code base entirely. My thinking here was the code should reflect the product terminology where applicable. I didn't see a related style that uses the term 'peer', but to simplify the PR I've removed that changed.

I updated the JS project to remove the term Peer their also, specifically the resetPeer command. I've linked to that PR in the description.

@sachaw
Copy link
Member

sachaw commented Mar 11, 2024

This is where the styling is documented: https://tailwindcss.com/docs/hover-focus-and-other-states#styling-based-on-sibling-state

@sachaw sachaw merged commit 38927d1 into meshtastic:master Mar 11, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants