Create somersault_modified.pdx dynamically #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Katja Köhler <katja.koehler@mbition.io>
The reason is that they are useful to be used outside of the submodule, e.g., if the database is going to be modified. Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Katja Köhler <katja.koehler@mbition.io>
instead of creating everything from scratch, it takes the "normal" somersault ECU and modifies this database. (This script thus serves as an example of how this can be done.) Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Katja Köhler <katja.koehler@mbition.io>
…d.pdx` thanks to [at]kakoeh for the feedback! Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Katja Köhler <katja.koehler@mbition.io>
…const portion The location of the `num_flips_done` parameter of the 'somersault.PR.happy_forward' is ouside of the constant prefix of the corresponding request. Although the spec does not explicitly disallow this, it is probably not intended to be done. Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Katja Köhler <katja.koehler@mbition.io>
andlaus
force-pushed
the
dynamic_somersault_modified
branch
from
2b59932
to
fde3d5a
Compare
|
@kayoub5: any opinion on this? I think that this one makes a nice template for copy-and-pasting but the code is relatively uncritical... |
kayoub5
requested changes
Apr 5, 2024
as usual, thanks to [at]kayoub5! Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Katja Köhler <katja.koehler@mbition.io>
kayoub5
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating this file from scratch, it takes the "normal" somersault ECU and modifies it programmatically. (This script thus serves as an example of how this can be done.)
The reason for this approach is to automatically carry over changes to the base
sommersaultecu, thus simplifying keeping these files in sync and having a well-defined set of modifications.Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH.
Provider Information