upgrade kubebuilder to plugin/v4 #418
Conversation
|
Tests currently failing will take a look |
|
@sanposhiho After upgrading kubebuilder, controller with name tortoise already exists. Controller names must be unique to avoid multiple controllers reporting to the same metric. This error appears for every controller test after the first test. The way the controller tests are written for tortoise is very different from the documentation so i'm not sure how to fix this.. do you know if its possible to delete this controller in the cleanup? |
|
What if you move startController() like this? runTest := func(path string) {
initializeResourcesFromFiles(ctx, k8sClient, filepath.Join(path, "before"))
- stopFunc = startController(ctx)
if os.Getenv("UPDATE_TESTCASES") == "true" {
generateTestCases(path)
} else {
checkWithWantedResources(path)
}
cleanUp()
}
+ BeforeEach(func() {
+ stopFunc = startController(ctx)
+ }) |
|
@sanposhiho I fixed it with this |
|
@sanposhiho Not sure what this exec error is for the tortoisectl test would you have any clue? |
cmd/tortoisectl/main.go
Outdated
|
|
||
| import "github.com/mercari/tortoise/cmd/tortoisectl/commands" | ||
|
|
||
| func main() { | ||
| func tortoisectl() { |
There was a problem hiding this comment.
why renamed like this? It might be the reason
|
@sanposhiho all the tests are passing but somehow lint is getting killed on the runner.. likely to be OOM? seems like the linter is using a lot of memory on the runner compared to my local |
Looks like go version issue. Specified go1.22.6 and it works now |
| @@ -120,8 +120,6 @@ func main() { | |||
|
|
|||
| mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{ | |||
| Scheme: scheme, | |||
| MetricsBindAddress: metricsAddr, | |||
There was a problem hiding this comment.
So, we no longer need a flag for metricAddr(L81)? How does it know the address?
| @@ -73,6 +73,10 @@ func Test_TortoiseCtlStop(t *testing.T) { | |||
|
|
|||
| // Build the latest binary. | |||
| buildTortoiseCtl(t) | |||
| _, _, err := execCommand(t, "chmod", "+x", "./testdata/bin/tortoisectl") | |||
There was a problem hiding this comment.
I believe it's not needed, is it?
| @@ -0,0 +1,122 @@ | |||
| /* | |||
There was a problem hiding this comment.
License is wrong.
https://github.com/mercari/tortoise/blob/main/LICENSE
| @@ -0,0 +1,32 @@ | |||
| /* | |||
| @@ -0,0 +1,140 @@ | |||
| /* | |||
What this PR does / why we need it:
In place upgrade for kubebuilder to plugin v4
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: