Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prop for styling the video element #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thomassuckow
Copy link

No description provided.

@mderrick
Copy link
Owner

Thanks for the PR! Whats the use case for this? Couldn't you just style from the parent className like .Video video {}

@thomassuckow
Copy link
Author

We have a requirement to apply css filters to the video dynamically from some sliders. Rather than trying to generate a style tag on the fly and manipulate it, it would be much easier to just specify the styles directly.

@thomassuckow
Copy link
Author

Ended up adding a styleTag and using to-css to manage generating the css from the object we would have applied to the style prop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants