Skip to content

Commit

Permalink
Merge pull request #65 from maxpert/optimize-nats-snapshot
Browse files Browse the repository at this point in the history
Optimizing NATS snapshotting for low memory environments
  • Loading branch information
maxpert authored Jul 23, 2023
2 parents 24b4c96 + 4c1e1df commit 899d425
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 8 deletions.
31 changes: 24 additions & 7 deletions snapshot/nats_storage.go
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
package snapshot

import (
"os"
"time"

"github.com/maxpert/marmot/cfg"
"github.com/maxpert/marmot/stream"
"github.com/nats-io/nats.go"
"github.com/rs/zerolog/log"
"os"
)

const hashHeaderKey = "marmot-snapshot-tag"
Expand Down Expand Up @@ -63,16 +65,31 @@ func (n *natsStorage) Download(filePath, name string) error {
return err
}

err = blb.GetFile(name, filePath)
if err == nats.ErrObjectNotFound {
return ErrNoSnapshotFound
}
for {
err = blb.GetFile(name, filePath)
if err == nil {
return nil
}

if err == nats.ErrObjectNotFound {
return ErrNoSnapshotFound
}

if jsmErr, ok := err.(nats.JetStreamError); ok {
log.Warn().
Err(err).
Int("Status", jsmErr.APIError().Code).
Msg("Error downloading snapshot, retrying...")
time.Sleep(time.Second)
continue
}

return err
return err
}
}

func getBlobStore(conn *nats.Conn) (nats.ObjectStore, error) {
js, err := conn.JetStream()
js, err := conn.JetStream(nats.MaxWait(30 * time.Second))
if err != nil {
return nil, err
}
Expand Down
2 changes: 1 addition & 1 deletion stream/embedded_nats.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func startEmbeddedServer(nodeName string) (*embeddedNats, error) {
Port: -1,
NoSigs: true,
JetStream: true,
JetStreamMaxMemory: 1 << 25,
JetStreamMaxMemory: 1 << 20,
JetStreamMaxStore: 1 << 30,
Cluster: server.ClusterOpts{
Name: "e-marmot",
Expand Down

0 comments on commit 899d425

Please sign in to comment.