config dl gimxfile rebase #636
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…status returns -3
Now prints to terminal. Needs fix for downloading as config download …
…y to browse truncated strings using left and right arrow keys.
…wnload correct files.
…enu needs to be implemented, to show the user which buttons to use to navigate this tool. Fixed a fatal mistake where local copy of ttyProgressDialog was being used again for config dl despite going out of scope.
merge updates
…n folder called 'fetchconfig'. Finally, added program to master Makefile - meaning the program can be built with the rest of the Gimx suite from the root folder.
… outdated commented code.
added 15 commits
September 19, 2019 14:19
…uffer size, in macros.c and btds4.c. I have marked them with comments and temporary warning exceptions. Unfortunately, I am not experienced enough to fix these issues.
…h gimx-launcher and fetchconfig use this library now.
added 7 commits
October 10, 2019 15:24
…earching for simpler substitute for std::function as this is the cause for this modification. Probably will just use function pointer.
… me to remove unnessessary -stdc++=14 CPPFLAG option. Also, clean up code.
|
Okay, so I think I have got everything done. There are no compilation warnings generated by my program, it is stable and does the job nicely. I finished up the command line argument parsing as well, because it was a mess. The code I copied from gimx-launcher for the automatic config download functionality has been moved to a common library, and all file operations now go through the gimxfile lib. Unfortunately, I cannot physically test this functionality as I do not have game controllers; however, it is using code proven to work so any issues should be easy to fix. Let me know if there is anything else I should do. For now, I think this will be all. |
matlo
force-pushed
the
gimxfile
branch
3 times, most recently
from
8d4fd83
to
0f8053a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.