83957 - Display API Example does not work #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MykolaAtMcLarenApplied
requested review from
wei-mclarenapplied and
salman-mclarenapplied
|
No comments with the code changes but I realised our readme.md is woefully simple. Should we take the opportunity to add just a few step instructions? i.e. build it, copy/paste into Atlas directory and launch Atlas.. something like that? Or however we intend these samples to be used. |
|
well, maybe yes, but also maybe no as 1) it was originally created by Lee S I believe, and 2) yes though it is laconic it is good enough for customer to be used, and finally 3) people in A10 team often moan that PR 'should not have a noise'. i.e. any other changes which are not relevant to the ticket. |
wei-mclarenapplied
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the bug with "ATLAS does not launch".
For the fix I added two more AssemblyInfo.cs file with corresponding content - that does the job