Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: hook up sphinx #185

Merged
merged 1 commit into from
Nov 13, 2023
Merged

doc: hook up sphinx #185

merged 1 commit into from
Nov 13, 2023

Conversation

whot
Copy link
Contributor

@whot whot commented Nov 7, 2023

For reference, this is how it looks like: https://whot.github.io/python-dbusmock/
Needs enabling in https://github.com/martinpitt/python-dbusmock/settings/pages, change to Source: Github Action.

This is the minimal conversion only, using the readme as index page and with a few rst-ifications in the DBusMockObject class (but not in DBusTestCase because that would conflict with #184). Once it's in place we can prettify all this one-by-one.

A helper Makefile is included too to build it locally.

@whot whot force-pushed the wip/sphinx branch 2 times, most recently from 0507684 to 25b9538 Compare November 7, 2023 02:17
Makefile Outdated Show resolved Hide resolved
doc/conf.py Outdated
project = 'python-dbusmock'
copyright = '2023, Martin Pitt' # noqa: A001
author = 'Martin Pitt'
release = '0.29.1'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to use the dynamic version like here.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to grep the source code and yes, it does show up:
<title>python-dbusmock &mdash; python-dbusmock 0.29.1 documentation</title>

Guess with everyone having a thousand tabs open no-one would notice that ;)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally the dynamic import works in the sense of sphinx-build succeeding. I pushed that.

I also added the two new directories to .gitignore.

Copy link
Owner

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is really nice! I'm waiting for CI to complete. I did the project settings change, so this ought to work after landing.

@martinpitt martinpitt merged commit 8d58557 into martinpitt:main Nov 13, 2023
20 checks passed
@martinpitt
Copy link
Owner

Et voilà: https://martinpitt.github.io/python-dbusmock/ 🚀

@whot
Copy link
Contributor Author

whot commented Nov 13, 2023

it's like the future! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants