Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option to convert dictionary values from strings #262

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

kip-hart
Copy link

@kip-hart kip-hart commented Nov 5, 2020

Added code to interpret strings in the dictionary value field to be interpreted as Python values (int, float, bool, etc). Default behavior remains unchanged, this additional step only occurs if convert_values=True in the parse function.

An example has been added to the parse docstring and to the list of unit tests.

PR is set as draft since I could not run tox on my local machine. I'll wait for Travis to run the tests and convert from draft to full PR once it's passing.

@kip-hart
Copy link
Author

kip-hart commented Nov 5, 2020

I've made fixes to pass the code on Travis. It is currently passing all environments except Jython. It looks like the error is unrelated to these changes (https://travis-ci.com/github/martinblech/xmltodict/jobs/428438169). Could you take a look and confirm?

@kip-hart kip-hart marked this pull request as ready for review November 5, 2020 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant