Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Tags API) Make templates renderers #2331

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Conversation

DylanPiercey
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Oct 21, 2024

🦋 Changeset detected

Latest commit: 5c47769

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@marko/translator-tags Patch
@marko/runtime-tags Patch
@marko/translator-interop-class-tags Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DylanPiercey DylanPiercey force-pushed the make-templates-renderers branch 2 times, most recently from e18e907 to 8c945da Compare October 21, 2024 17:13
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 87.32106% with 62 lines in your changes missing coverage. Please review.

Project coverage is 88.74%. Comparing base (7199f87) to head (5c47769).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
packages/translator-tags/src/core/html-comment.ts 39.62% 32 Missing ⚠️
packages/runtime-tags/src/dom/template.ts 85.54% 12 Missing ⚠️
packages/runtime-tags/src/dom/signals.ts 60.00% 4 Missing ⚠️
packages/runtime-tags/src/html/template.ts 91.89% 3 Missing ⚠️
packages/runtime-tags/src/html/writer.ts 70.00% 3 Missing ⚠️
packages/translator-tags/src/util/signals.ts 88.46% 3 Missing ⚠️
packages/runtime-tags/src/dom/renderer.ts 97.77% 2 Missing ⚠️
packages/runtime-tags/src/common/helpers.ts 83.33% 1 Missing ⚠️
packages/runtime-tags/src/dom/control-flow.ts 96.96% 1 Missing ⚠️
packages/runtime-tags/src/html/dynamic-tag.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2331      +/-   ##
==========================================
- Coverage   88.75%   88.74%   -0.02%     
==========================================
  Files         338      339       +1     
  Lines       35281    35337      +56     
  Branches     2089     2098       +9     
==========================================
+ Hits        31314    31360      +46     
- Misses       3951     3966      +15     
+ Partials       16       11       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit 8fe4e50 into main Oct 22, 2024
7 checks passed
@DylanPiercey DylanPiercey deleted the make-templates-renderers branch October 22, 2024 17:24
@github-actions github-actions bot mentioned this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant