Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare to merge #2003

Merged
merged 11 commits into from
Jul 24, 2023
Merged

Prepare to merge #2003

merged 11 commits into from
Jul 24, 2023

Conversation

mlrawlings
Copy link
Member

Description

Preparation to merge in marko-js/x

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2023

⚠️ No Changeset found

Latest commit: 0c4b8fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 85.06% and project coverage change: -0.99 ⚠️

Comparison is base (e523252) 89.95% compared to head (0c4b8fc) 88.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2003      +/-   ##
==========================================
- Coverage   89.95%   88.96%   -0.99%     
==========================================
  Files         218      212       -6     
  Lines        6827    17413   +10586     
==========================================
+ Hits         6141    15491    +9350     
- Misses        686     1922    +1236     
Impacted Files Coverage Δ
packages/compiler/src/register.js 0.00% <0.00%> (ø)
packages/marko/src/compiler/modules.js 0.00% <0.00%> (ø)
packages/marko/src/node-require/browser-refresh.js 27.77% <0.00%> (-9.73%) ⬇️
packages/marko/src/runtime/vdom/VFragment.js 73.07% <0.00%> (-26.93%) ⬇️
packages/marko/src/runtime/vdom/VNode.js 85.29% <0.00%> (-12.27%) ⬇️
packages/marko/src/runtime/vdom/hot-reload.js 0.00% <0.00%> (ø)
packages/marko/src/taglib/index.js 70.00% <0.00%> (-7.28%) ⬇️
packages/marko/src/runtime/RenderResult.js 62.16% <33.33%> (-16.91%) ⬇️
...kages/marko/src/runtime/components/ComponentDef.js 66.45% <33.33%> (-22.44%) ⬇️
packages/compiler/src/taglib/loader/Taglib.js 73.11% <50.00%> (-4.66%) ⬇️
... and 72 more

... and 143 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mlrawlings mlrawlings merged commit 59dd026 into main Jul 24, 2023
7 of 9 checks passed
@DylanPiercey DylanPiercey deleted the merge-next branch January 8, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant