Skip to content

Commit

Permalink
fix: ensure .marko files resolved for renderer config
Browse files Browse the repository at this point in the history
  • Loading branch information
DylanPiercey committed Aug 14, 2023
1 parent af3e6c2 commit 6afd00f
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 1 deletion.
7 changes: 7 additions & 0 deletions .changeset/plenty-poems-attack.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@marko/compiler": patch
"marko": patch
"@marko/translator-default": patch
---

Ensure .marko files are resolved for legacy renderer taglib configs.
18 changes: 17 additions & 1 deletion packages/compiler/src/taglib/loader/loadTagFromProps.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,22 @@ function resolveRelative(dirname, value) {
return value[0] === "." ? resolveFrom(dirname, value) : value;
}

function resolveWithMarkoExt(dirname, value) {
if (
markoModules.require.extensions &&
!(".marko" in markoModules.require.extensions)
) {
markoModules.require.extensions[".marko"] = undefined;
try {
return resolveFrom(dirname, value);
} finally {
delete markoModules.require.extensions[".marko"];
}
}

return resolveFrom(dirname, value);
}

function removeDashes(str) {
return str.replace(/-([a-z])/g, function (match, lower) {
return lower.toUpperCase();
Expand Down Expand Up @@ -300,7 +316,7 @@ class TagLoader {
* @param {String} value The renderer path
*/
renderer(value) {
this.tag.renderer = resolveRelative(this.dirname, value);
this.tag.renderer = resolveWithMarkoExt(this.dirname, value);
}

/**
Expand Down

0 comments on commit 6afd00f

Please sign in to comment.