Add hexside_length for newer tmx. #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleokdev
reviewed
Oct 22, 2024
|
Please also update CHANGELOG.md and select the |
|
I didn't know which should been in the CHANGELOG.md, so I cannot fix this conflicts . |
|
Alright, I'll fix it |
|
Had to rebase your branch to merge into |
aleokdev
previously approved these changes
Oct 22, 2024
|
GH Actions froze because of the CI skip on the previous commit lol |
aleokdev
previously approved these changes
Oct 22, 2024
bjorn
reviewed
Oct 22, 2024
src/map.rs
Outdated
| @@ -56,6 +56,8 @@ pub struct Map { | |||
| /// individual tiles may have different sizes. As such, there is no guarantee that this value | |||
| /// will be the same as the one from the tilesets the map is using. | |||
| pub tile_height: u32, | |||
| /// The length of the side of a hexagonal tile in pixels (Used by tile layers on hexagonal maps). | |||
There was a problem hiding this comment.
Suggested change
| /// The length of the side of a hexagonal tile in pixels (Used by tile layers on hexagonal maps). | |
| /// The length of the side of a hexagonal tile in pixels (used by tile layers on hexagonal maps). |
aleokdev
approved these changes
Oct 22, 2024
|
Whoops, I missed that a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of tmx (new version?) file has this attarbute. And i found other tmx library also has this attribute. We need this!