Fixed template instance size and position overrides #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn
force-pushed
the
fix-shape-size-override
branch
2 times, most recently
from
3a6798c
to
f0cad80
Compare
|
Whoops, I should have opened this PR from my personal fork. |
|
I guess it would be good to add some kind of test for overriding size in a template instance... |
Template instances of rectangle, ellipse and text objects can override the width and height of the template object. This is now taken into account when reading out the attributes and when inheriting the shape from the template. Template instances of point objects are now also correctly storing the instance position in the Point shape, instead of the position of the template object. Added a small test for the resized templated object case. Closes #310
bjorn
force-pushed
the
fix-shape-size-override
branch
from
f0cad80
to
1eaf05b
Compare
|
@aleokdev Thanks! Most annoying was the handling of the Text objects, heh. What a bunch of boilerplate, which I don't think I could avoid thanks to it being an enum variant rather than a plain struct. I decided to add a small test to verify the behavior. |
aleokdev
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template instances of rectangle, ellipse and text objects can override the width and height of the template object. This is now taken into account when reading out the attributes and when inheriting the shape from the template.
Template instances of point objects are now also correctly storing the instance position in the Point shape, instead of the position of the template object.
Closes #310