Merge pull request #121 from manifoldco/dangodev/ts

Tighten TS restrictions

.eslintrc.js

@@ -32,6 +32,7 @@ module.exports = {
     '@typescript-eslint/camelcase': 'off',
     '@typescript-eslint/explicit-function-return-type': 'off',
     '@typescript-eslint/explicit-member-accessibility': 'off',
+    '@typescript-eslint/no-empty-function': 'off', // why are you like this
     '@typescript-eslint/no-unused-vars': 'off', // compiler catches these well enough
     'arrow-parens': 'off', // let Prettier decide
     camelcase: 'off', // underscores are a thing

.github/pull_request_template.md

@@ -0,0 +1,25 @@
+## Change
+
+<!-- What does this change and why do we need it? In plain language. -->
+<!-- A demo may be helpful such as a: loom video, gif, before/after shots, a short call, some data output or logs  -->
+
+## How does it work
+
+<!-- Explain how it works and how it achieves the desired outcome. -->
+
+## Testing
+
+<!-- For someone unfamiliar with the issue, how should this be tested? -->
+
+## Debugging and observability
+
+<!-- If something goes wrong here how will you know? logs? traces? metrics? -->
+<!-- What questions do you want to be able to answer about this change? -->
+<!-- If this breaks how will you fix it, or know what to fix? -->
+<!-- How can you check on what is happening? How do you look into it? -->
+
+## Documentation
+
+<!-- Does documentation need to be added? -->
+<!-- Branch name, commits and code comments should be clear and document the change. -->
+<!-- Additional documentation is encouraged to help future maintainers. -->

.github/workflows/auto_approve.yml

@@ -6,10 +6,10 @@ on:
       - opened
 
 jobs:
-  build:
+  approve:
+    if: github.actor == 'dependabot[bot]' || github.actor == 'dependabot-preview[bot]'
     runs-on: ubuntu-latest
     steps:
       - uses: hmarr/auto-approve-action@v2.0.0
-        if: github.actor == 'dependabot[bot]' || github.actor == 'dependabot-preview[bot]'
         with:
           github-token: '${{ secrets.GITHUB_TOKEN }}'

.github/workflows/branch.yml → .github/workflows/pull_request.yml

@@ -1,4 +1,4 @@
-name: branch
+name: pull_request
 
 on: [pull_request]
 
@@ -7,31 +7,38 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [10.x, 12.x, 13.x]
+        node-version: [10.x, 12.x, 14.x]
     steps:
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v2
       - uses: actions/setup-node@v1
       - run: npm install
       - run: npm run build
   bundlesize:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v2
       - uses: actions/setup-node@v1
       - run: npm install
       - run: npm run bundlesize
   test:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v2
       - uses: actions/setup-node@v1
       - run: npm install
       - run: npm run test:coverage
       - run: npx codecov
   lint:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v2
       - uses: actions/setup-node@v1
       - run: npm install
       - run: npm run lint
+  typecheck:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-node@v1
+      - run: npm install
+      - run: npm run typecheck